Re: [Qemu-devel] [PATCH RFC 1/6] hw/acpi: remove dead acpi code

[Igor Mammedov]

On Fri, 30 Jun 2017 02:27:40 +0300
"Michael S. Tsirkin" <address@hidden> wrote:

> On Fri, Jun 30, 2017 at 12:55:57AM +0300, Aleksandr Bezzubikov wrote:
> > Signed-off-by: Aleksandr Bezzubikov <address@hidden>  
> 
> 
> I agree it seems unused. I'm not sure why do we have this
> code. Igor?
it's leftovers of original ASL code from SeaBIOS,
my conversion only was 1:1 from ASL to AML to avoid regressions
and almost no cleanups has been done on result.

It should be safe to remove these objects as they are not used by
Q35 (no AML or hw users for these ports)

Reviewed-by: Igor Mammedov <address@hidden>

> 
> > ---
> >  hw/i386/acpi-build.c | 10 ----------
> >  1 file changed, 10 deletions(-)
> > 
> > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> > index afcadac..6fce967 100644
> > --- a/hw/i386/acpi-build.c
> > +++ b/hw/i386/acpi-build.c
> > @@ -1912,16 +1912,6 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
> >          build_piix4_pci0_int(dsdt);
> >      } else {
> >          sb_scope = aml_scope("_SB");
> > -        aml_append(sb_scope,
> > -            aml_operation_region("PCST", AML_SYSTEM_IO, aml_int(0xae00), 
> > 0x0c));
> > -        aml_append(sb_scope,
> > -            aml_operation_region("PCSB", AML_SYSTEM_IO, aml_int(0xae0c), 
> > 0x01));
> > -        field = aml_field("PCSB", AML_ANY_ACC, AML_NOLOCK, 
> > AML_WRITE_AS_ZEROS);
> > -        aml_append(field, aml_named_field("PCIB", 8));
> > -        aml_append(sb_scope, field);
> > -        aml_append(dsdt, sb_scope);
> > -
> > -        sb_scope = aml_scope("_SB");
> >          dev = aml_device("PCI0");
> >          aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A08")));
> >          aml_append(dev, aml_name_decl("_CID", aml_eisaid("PNP0A03")));
> > -- 
> > 2.7.4