Re: [Qemu-devel] postcopy migration hangs while loading virtio state

[Dr. David Alan Gilbert]

* Michael S. Tsirkin (address@hidden) wrote:
> On Fri, Jun 30, 2017 at 05:31:39PM +0100, Dr. David Alan Gilbert wrote:
> > * Christian Borntraeger (address@hidden) wrote:
> > > On 04/26/2017 01:45 PM, Christian Borntraeger wrote:
> > > 
> > > >> Hmm, I have a theory, if the flags field has bit 1 set, i.e. 
> > > >> RAM_SAVE_FLAG_COMPRESS
> > > >> then try changing ram_handle_compressed to always do the memset.
> > > > 
> > > > FWIW, changing ram_handle_compressed to always memset makes the problem 
> > > > go away.
> > > 
> > > It is still running fine now with the "always memset change"
> > 
> > Did we ever nail down a fix for this; as I remember Andrea said
> > we shouldn't need to do that memset, but we came to the conclusion
> > it was something specific to how s390 protection keys worked.
> > 
> > Dave
> 
> No we didn't. Let's merge that for now, with a comment that
> we don't really understand what's going on?

Hmm no, I don't really want to change the !s390 behaviour, especially
since it causes allocation that we otherwise avoid and Andrea's
reply tothe original post pointed out it's not necessary.

Dave

> > --
> > Dr. David Alan Gilbert / address@hidden / Manchester, UK
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK