Re: [Qemu-devel] [PATCH v3 1/1] s390x: vmstatify config migration for virtio-ccw

[Cornelia Huck]

Am Mon,  3 Jul 2017 23:34:14 +0200
schrieb Halil Pasic <address@hidden>:

> Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for
> flexibility (extending using subsections) and for fun.
> 
> To achieve this we need to hack the config_vector, which is
> VirtIODevice (that is common virtio) state, in the middle of the
> VirtioCcwDevice state representation.  This is somewhat ugly, but we
> have no choice because the stream format needs to be preserved.
> 
> Almost no changes in behavior. Exception is everything that comes with
> vmstate like extra bookkeeping about what's in the stream, and maybe
> some extra checks and better error reporting.
> 
> Signed-off-by: Halil Pasic <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> Reviewed-by: Juan Quintela <address@hidden>
> Reviewed-by: Cornelia Huck <address@hidden>
> ---
> 
> I was pondering whether to drop or to keep the r-b's I've got for v2.
> I've decided to keep the r-b's because the change corresponding to v3
> are IMHO non-substantive and  because the patch isn't exactly small
> (can't be re-reviewed in a couple of seconds).
> 
> All r-b people are on cc and encouraged to scream at me if they don't
> agree to keep their r-b.

No screams from me, I don't think the changes are substantive enough to
drop my r-b.

(I haven't looked at the new patch in detail.)