[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 06/15] kvmvapic: remove tcg related code
From: |
Zhong Yang |
Subject: |
Re: [Qemu-devel] [PATCH v2 06/15] kvmvapic: remove tcg related code |
Date: |
Tue, 4 Jul 2017 10:46:22 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Jul 03, 2017 at 04:28:00PM +0200, Paolo Bonzini wrote:
>
>
> On 03/07/2017 12:12, Yang Zhong wrote:
> > Since Paolo's below patch has fixed A20 issue
> > commit bbfa326fc8028e275eddf8c9965c2a1b59405b2e
> > target/i386: enable A20 automatically in system management mod
>
> How is this patch related to kvmvapic? It fixes a bug with vapic
> disabled, but it's not a reason to disable kvmvapic.
>
> Paolo
>
Hello Paolo,
In that time, in order to verify the tcg code is not useful in kvmvapic.c
file, we disabled the kvmvapic rom in the seabios and use the tcg accelator
to boot guest image, we found this A20 bug.
Once this A20 bug has been fixed, we can use the tcg to bootup the guest
image without kvmvapic rom, which show the tcg code in kvmvapic is not useful.
This is reason why i removed the tcg code replace of using tcg_enabled() to
check
the tcg code in kvmvapic.c. thanks!
Regards,
Yang
> > The tcg code in kvmvapic.c is NOT useful, those code need remove.
> >
> > Signed-off-by: Yang Zhong <address@hidden>
> > ---
> > hw/i386/kvmvapic.c | 24 ------------------------
> > 1 file changed, 24 deletions(-)
- Re: [Qemu-devel] [PATCH v2 01/15] configure: add the disable-tcg option, (continued)
- [Qemu-devel] [PATCH v2 02/15] vl: add tcg_enabled() for tcg related code, Yang Zhong, 2017/07/03
- [Qemu-devel] [PATCH v2 03/15] tcg: tcg_handle_interrupt() function, Yang Zhong, 2017/07/03
- [Qemu-devel] [PATCH v2 04/15] tcg: change tcg_enabled(), Yang Zhong, 2017/07/03
- [Qemu-devel] [PATCH v2 05/15] tcg: move page_size_init() function, Yang Zhong, 2017/07/03
- [Qemu-devel] [PATCH v2 07/15] tcg: move cpu_sync_bndcs_hflags() function, Yang Zhong, 2017/07/03
- [Qemu-devel] [PATCH v2 06/15] kvmvapic: remove tcg related code, Yang Zhong, 2017/07/03
- [Qemu-devel] [PATCH v2 08/15] tcg: make cpu_get_fp80()/cpu_set_fp80() static, Yang Zhong, 2017/07/03
- [Qemu-devel] [PATCH v2 09/15] tcg: add the tcg-stub.c file into accel/stubs/, Yang Zhong, 2017/07/03
- [Qemu-devel] [PATCH v2 10/15] tcg: move tb related lock functions, Yang Zhong, 2017/07/03
- [Qemu-devel] [PATCH v2 11/15] tcg: split cpu_set_mxcsr() and make cpu_set_fpuc() inline, Yang Zhong, 2017/07/03
- [Qemu-devel] [PATCH v2 12/15] tcg: disable tcg in CPUX86State struct, Yang Zhong, 2017/07/03
- [Qemu-devel] [PATCH v2 13/15] tcg: add the CONFIG_TCG for header, Yang Zhong, 2017/07/03
- [Qemu-devel] [PATCH v2 14/15] tcg: add the tcg_enabled() in target/i386/, Yang Zhong, 2017/07/03
- [Qemu-devel] [PATCH v2 15/15] tcg: add the CONFIG_TCG into Makefiles, Yang Zhong, 2017/07/03