[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 11/13] virtio-console: chardev hotswap suppor
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH v4 11/13] virtio-console: chardev hotswap support |
Date: |
Tue, 4 Jul 2017 08:25:27 +0200 |
On (Mon) 03 Jul 2017 [14:50:07], Anton Nefedov wrote:
> On 06/29/2017 01:02 PM, Marc-André Lureau wrote:
> > Hi
> >
> > Looks good, but please write something in the commit message about what
> > needs to be done for be-change (what this patch does).
> >
> > thanks
> >
>
> Hi,
>
> thank you! I guess the description should look like
>
> virtio-console: chardev hotswap support
>
> In case of a backend change, the handler functions and the watch have
> to be reset.
> Also, avoid unsafe qemu_chr_fe_get_driver() usage even though the pointer
> is not really stored.
>
>
>
> Amit, have you had a chance to kindly look at this?
If it gets a reviewed-by by someone who's looked at the series,
Michael could pull it all in.
I could look at it if you CC'ed me on the series (hint ;)
Amit
--
http://log.amitshah.net/