qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 14/22] tcg: add CONFIG_TCG guards in headers


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 14/22] tcg: add CONFIG_TCG guards in headers
Date: Tue, 4 Jul 2017 11:35:17 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0


On 03/07/2017 22:10, Richard Henderson wrote:
> On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
>> --- a/include/exec/helper-proto.h
>> +++ b/include/exec/helper-proto.h
>> @@ -28,7 +28,9 @@ dh_ctype(ret) HELPER(name) (dh_ctype(t1),
>> dh_ctype(t2), dh_ctype(t3), \
>>     #include "helper.h"
>>   #include "trace/generated-helpers.h"
>> +#ifdef CONFIG_TCG
>>   #include "tcg-runtime.h"
>> +#endif
> 
> Do we really want to define any of the helpers if !CONFIG_TCG?
> Perhaps it's the user of this header that needs adjustment.

Indeed, this hunk is not needed anymore after my other cleanups.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]