Re: [Qemu-devel] [PATCH 2/7] s390x/3270: fix instruction interception handler

[Cornelia Huck]

On Tue,  4 Jul 2017 16:07:54 +0200
Christian Borntraeger <address@hidden> wrote:

> From: Dong Jia Shi <address@hidden>
> 
> Commit bab482d7405f ("s390x/css: ccw translation infrastructure")
> introduced instruction interception handler for different types of
> subchannels. For emulated 3270 devices, we should assign the virtual
> subchannel handler to them during device realization process, or 3270
> will not work.
> 
> Fixes: bab482d7405f ("s390x/css: ccw translation infrastructure")
> 
> Reviewed-by: Jing Liu <address@hidden>
> Reviewed-by: Halil Pasic <address@hidden>
> Signed-off-by: Dong Jia Shi <address@hidden>
> Signed-off-by: Christian Borntraeger <address@hidden>
> ---
>  hw/s390x/3270-ccw.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/s390x/3270-ccw.c b/hw/s390x/3270-ccw.c
> index 6e6eee4..1554aa2 100644
> --- a/hw/s390x/3270-ccw.c
> +++ b/hw/s390x/3270-ccw.c
> @@ -126,6 +126,7 @@ static void emulated_ccw_3270_realize(DeviceState *ds, 
> Error **errp)
>      sch->id.cu_type = EMULATED_CCW_3270_CU_TYPE;
>      css_sch_build_virtual_schib(sch, (uint8_t)chpid,
>                                  EMULATED_CCW_3270_CHPID_TYPE);
> +    sch->do_subchannel_work = do_subchannel_work_virtual;
>      sch->ccw_cb = emulated_ccw_3270_cb;
>  
>      ck->init(dev, &err);

Reviewed-by: Cornelia Huck <address@hidden>