[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/6] nbd/client: refactor TRACE of NBD_MAGIC
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 5/6] nbd/client: refactor TRACE of NBD_MAGIC |
|
Date: |
Wed, 5 Jul 2017 17:21:55 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 29/06/2017 21:36, Eric Blake wrote:
>> + memcpy(&nbd_magic, buf, 8);
>> + nbd_magic = be64_to_cpu(nbd_magic);
> Do we really need to copy the memory around twice? Can't we just use:
> magic = ldq_be_p(buf);
> and call it good?
Yes.
Paolo
signature.asc
Description: OpenPGP digital signature
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v2 5/6] nbd/client: refactor TRACE of NBD_MAGIC,
Paolo Bonzini <=