[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v3 1/3] util/qemu-error: Rename error_print_loc()
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [RFC v3 1/3] util/qemu-error: Rename error_print_loc() to be more generic |
Date: |
Thu, 6 Jul 2017 04:36:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 05.07.2017 19:36, Alistair Francis wrote:
> Rename the error_print_loc() function in preparation for using it to
> print warnings as well.
>
> Signed-off-by: Alistair Francis <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>
> util/qemu-error.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/util/qemu-error.c b/util/qemu-error.c
> index b331f8f4a4..1c5e35ecdb 100644
> --- a/util/qemu-error.c
> +++ b/util/qemu-error.c
> @@ -146,7 +146,7 @@ const char *error_get_progname(void)
> /*
> * Print current location to current monitor if we have one, else to stderr.
> */
> -static void error_print_loc(void)
> +static void print_loc(void)
> {
> const char *sep = "";
> int i;
> @@ -197,7 +197,7 @@ void error_vreport(const char *fmt, va_list ap)
> g_free(timestr);
> }
>
> - error_print_loc();
> + print_loc();
> error_vprintf(fmt, ap);
> error_printf("\n");
> }
Reviewed-by: Thomas Huth <address@hidden>
- Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting, (continued)
- Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting, Markus Armbruster, 2017/07/06
- Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting, Daniel P. Berrange, 2017/07/06
- Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting, Markus Armbruster, 2017/07/06
- Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting, Daniel P. Berrange, 2017/07/06
- Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting, Markus Armbruster, 2017/07/06
- Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting, Alistair Francis, 2017/07/06
[Qemu-devel] [RFC v3 3/3] char-socket: Report TCP socket waiting as information, Alistair Francis, 2017/07/05
[Qemu-devel] [RFC v3 1/3] util/qemu-error: Rename error_print_loc() to be more generic, Alistair Francis, 2017/07/05
- Re: [Qemu-devel] [RFC v3 1/3] util/qemu-error: Rename error_print_loc() to be more generic,
Thomas Huth <=