[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check ca
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback |
|
Date: |
Thu, 6 Jul 2017 15:29:55 +0800 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Thu, 07/06 00:16, address@hidden wrote:
> /var/tmp/patchew-tester-tmp-s55a7o8g/src/hw/virtio/virtio-crypto.c: In
> function ‘virtio_crypto_instance_init’:
> /var/tmp/patchew-tester-tmp-s55a7o8g/src/hw/virtio/virtio-crypto.c:918:30:
> error: passing argument 5 of ‘object_property_add_link’ from incompatible
> pointer type [-Werror=incompatible-pointer-types]
> virtio_crypto_check_cryptodev_is_used,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from
> /var/tmp/patchew-tester-tmp-s55a7o8g/src/include/hw/hw.h:10:0,
> from
> /var/tmp/patchew-tester-tmp-s55a7o8g/src/include/hw/qdev.h:4,
> from
> /var/tmp/patchew-tester-tmp-s55a7o8g/src/hw/virtio/virtio-crypto.c:15:
> /var/tmp/patchew-tester-tmp-s55a7o8g/src/include/qom/object.h:1353:6: note:
> expected ‘void (*)(const Object *, const char *, Object *, Error **) {aka
> void (*)(const struct Object *, const char *, struct Object *, struct Error
> **)}’ but argument is of type ‘void (*)(Object *, const char *, Object *,
> Error **) {aka void (*)(struct Object *, const char *, struct Object *,
> struct Error **)}’
> void object_property_add_link(Object *obj, const char *name,
> ^~~~~~~~~~~~~~~~~~~~~~~~
No worry, I've taken care of it when including this patch in my series.
Fam