[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/4] xen/mapcache: introduce xen_replace_cach
From: |
Paul Durrant |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/4] xen/mapcache: introduce xen_replace_cache_entry() |
Date: |
Thu, 6 Jul 2017 09:50:51 +0000 |
> -----Original Message-----
> > > >
> > > > The problem really comes down to defining
> xenforeignmemory_map2() in
> > > terms of xenforeignmemory_map(). It basically can't be safely done.
> Could
> > > you define xenforeignmemory_map2() as abort() in the compat case
> > > instead?
> > > >
> > >
> > > xen_replace_cache_entry() is not called in patch #3. Which means it's
> > > safe to use a fallback version (xenforeignmemory_map) in
> > > xen_remap_bucket here.
> >
> > I still don't like the fact that the compat definition of
> xenforeignmemory_map2() loses the extra argument. That's going to catch
> someone out one day. Is there any way you could re-work it so that
> xenforeignmemory_map() is uses in the cases where the memory
> placement does not matter?
>
> We could assert(vaddr == NULL) in the compat implementation of
> xenforeignmemory_map2. Would that work?
>
Yes, if the patch was changed from being a straight #define as it is now to an
inline that had such an assertion then that would be ok.
Cheers,
Paul
- [Qemu-devel] [PATCH v2 2/4] xen/mapcache: add an ability to create dummy mappings, (continued)
- [Qemu-devel] [PATCH v2 2/4] xen/mapcache: add an ability to create dummy mappings, Igor Druzhinin, 2017/07/04
- [Qemu-devel] [PATCH v2 3/4] xen/mapcache: introduce xen_replace_cache_entry(), Igor Druzhinin, 2017/07/04
- Re: [Qemu-devel] [PATCH v2 3/4] xen/mapcache: introduce xen_replace_cache_entry(), Paul Durrant, 2017/07/04
- Re: [Qemu-devel] [PATCH v2 3/4] xen/mapcache: introduce xen_replace_cache_entry(), Igor Druzhinin, 2017/07/04
- Re: [Qemu-devel] [PATCH v2 3/4] xen/mapcache: introduce xen_replace_cache_entry(), Paul Durrant, 2017/07/04
- Re: [Qemu-devel] [PATCH v2 3/4] xen/mapcache: introduce xen_replace_cache_entry(), Igor Druzhinin, 2017/07/04
- Re: [Qemu-devel] [PATCH v2 3/4] xen/mapcache: introduce xen_replace_cache_entry(), Paul Durrant, 2017/07/05
- Re: [Qemu-devel] [PATCH v2 3/4] xen/mapcache: introduce xen_replace_cache_entry(), Stefano Stabellini, 2017/07/05
- Re: [Qemu-devel] [PATCH v2 3/4] xen/mapcache: introduce xen_replace_cache_entry(),
Paul Durrant <=
Re: [Qemu-devel] [PATCH v2 3/4] xen/mapcache: introduce xen_replace_cache_entry(), Stefano Stabellini, 2017/07/05
[Qemu-devel] [PATCH v2 4/4] xen: don't use xenstore to save/restore physmap anymore, Igor Druzhinin, 2017/07/04
Re: [Qemu-devel] [PATCH v2 0/4] xen: don't save/restore the physmap on VM save/restore, no-reply, 2017/07/06