[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/7] MAINTAINERS: add Dump maintainers
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH 7/7] MAINTAINERS: add Dump maintainers |
Date: |
Thu, 6 Jul 2017 12:17:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/06/17 11:54, Marc-André Lureau wrote:
> Hi
>
> ----- Original Message -----
>> On 06/29/17 15:23, Marc-André Lureau wrote:
>>> Proposing myself, since I have some familiarity with the code now.
>>>
>>> Signed-off-by: Marc-André Lureau <address@hidden>
>>> ---
>>> MAINTAINERS | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 839f7ca063..45a0eb4cb0 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -1272,6 +1272,13 @@ S: Maintained
>>> F: device_tree.c
>>> F: include/sysemu/device_tree.h
>>>
>>> +Dump
>>> +S: Supported
>>> +M: Marc-André Lureau <address@hidden>
>>> +F: dump.c
>>> +F: include/sysemu/dump.h
>>> +F: include/sysemu/dump-arch.h
>>> +
>>> Error reporting
>>> M: Markus Armbruster <address@hidden>
>>> S: Supported
>>>
>>
>> That's very kind of you, thanks!
>>
>> Do you have suggestions for the following files?
>>
>> scripts/dump-guest-memory.py
>
> This one is yours, no? :) But I am ok to "support" it, meaning I'll take time
> to review the patches, and eventually make the pull-requests.
It used to be "mine" until (a) it got rewritten in object-oriented
Python, and (b) it received multi-arch support ;)
>
>> stubs/dump.c
>
> I can add that one, although it is also maintained by Paolo
>
>> target/arm/arch_dump.c
>> target/i386/arch_dump.c
>> target/ppc/arch_dump.c
>> target/s390x/arch_dump.c
>
> I'd rather have those maintained by the respective arch maintainers, as they
> are. But I imagine it would make sense to also cover them with the rest of
> dump.
Yeah there's an overlap here -- I'm not suggesting that you take on
everything, just curious what you think. I'm fine with this patch as it is.
Thanks
Laszlo