[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 08/21] mirror: Switch MirrorBlockJob to byte-
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v4 08/21] mirror: Switch MirrorBlockJob to byte-based |
Date: |
Thu, 6 Jul 2017 12:42:24 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 05.07.2017 um 23:08 hat Eric Blake geschrieben:
> We are gradually converting to byte-based interfaces, as they are
> easier to reason about than sector-based. Continue by converting an
> internal structure (no semantic change), and all references to the
> buffer size.
>
> Add an assertion that our use of s->granularity >> BDRV_SECTOR_BITS
> (necessary for interaction with sector-based dirty bitmaps, until
> a later patch converts those to be byte-based) does not suffer from
> truncation problems.
>
> [checkpatch has a false positive on use of MIN() in this patch]
>
> Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
- [Qemu-devel] [PATCH v4 01/21] blockjob: Track job ratelimits via bytes, not sectors, (continued)
- [Qemu-devel] [PATCH v4 01/21] blockjob: Track job ratelimits via bytes, not sectors, Eric Blake, 2017/07/05
- [Qemu-devel] [PATCH v4 03/21] stream: Switch stream_populate() to byte-based, Eric Blake, 2017/07/05
- [Qemu-devel] [PATCH v4 07/21] commit: Switch commit_run() to byte-based, Eric Blake, 2017/07/05
- [Qemu-devel] [PATCH v4 10/21] mirror: Update signature of mirror_clip_sectors(), Eric Blake, 2017/07/05
- [Qemu-devel] [PATCH v4 06/21] commit: Switch commit_populate() to byte-based, Eric Blake, 2017/07/05
- [Qemu-devel] [PATCH v4 02/21] trace: Show blockjob actions via bytes, not sectors, Eric Blake, 2017/07/05
- [Qemu-devel] [PATCH v4 05/21] stream: Switch stream_run() to byte-based, Eric Blake, 2017/07/05
- [Qemu-devel] [PATCH v4 08/21] mirror: Switch MirrorBlockJob to byte-based, Eric Blake, 2017/07/05
- [Qemu-devel] [PATCH v4 09/21] mirror: Switch mirror_do_zero_or_discard() to byte-based, Eric Blake, 2017/07/05
- [Qemu-devel] [PATCH v4 11/21] mirror: Switch mirror_cow_align() to byte-based, Eric Blake, 2017/07/05
- [Qemu-devel] [PATCH v4 12/21] mirror: Switch mirror_do_read() to byte-based, Eric Blake, 2017/07/05
- [Qemu-devel] [PATCH v4 13/21] mirror: Switch mirror_iteration() to byte-based, Eric Blake, 2017/07/05
- [Qemu-devel] [PATCH v4 14/21] block: Drop unused bdrv_round_sectors_to_clusters(), Eric Blake, 2017/07/05