Re: [Qemu-devel] [PATCH v11 13/29] target/i386: [tcg] Port to generic translation framework

[Lluís Vilanova]

Emilio G Cota writes:

> On Wed, Jun 28, 2017 at 16:09:06 +0300, Lluís Vilanova wrote:
[...]
>> diff --git a/target/i386/translate.c b/target/i386/translate.c
>> index 3950fe95a4..295be26a95 100644
>> --- a/target/i386/translate.c
>> +++ b/target/i386/translate.c
> (snip)
>> @@ -8544,111 +8548,23 @@ static void i386_trblock_disas_log(const 
>> DisasContextBase *dcbase,
>> 
>> }
>> 
>> +static const TranslatorOps i386_trblock_ops = {
>> +    .init_disas_context = i386_trblock_init_disas_context,
>> +    .init_globals = i386_trblock_init_globals,
>> +    .tb_start = i386_trblock_tb_start,
>> +    .insn_start = i386_trblock_insn_start,
>> +    .breakpoint_check = i386_trblock_breakpoint_check,
>> +    .translate_insn = i386_trblock_translate_insn,
>> +    .tb_stop = i386_trblock_tb_stop,
>> +    .disas_log = i386_trblock_disas_log,
>> +};

> I like hard tabs here, which make things visually easier, e.g.:

>> +static const TranslatorOps i386_trblock_ops = {
>> +    .init_disas_context     = i386_trblock_init_disas_context,
>> +    .init_globals           = i386_trblock_init_globals,

> Don't know whether checkpatch likes it, but I do, and I see some
> examples in the code base.

According to the guidelines, not tabs should be used (and I'm assuming
checkpatch looks for that). The best I can do is to space-align these.


Thanks,
  Lluis