Re: [Qemu-devel] [PATCH] chardev: block during sync read

[Paolo Bonzini]

On 06/07/2017 19:03, Marc-André Lureau wrote:
> A sync read should block until all requested data is
> available (instead of retrying in qemu_chr_fe_read_all). Change the
> channel to blocking during sync_read.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  chardev/char-socket.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/chardev/char-socket.c b/chardev/char-socket.c
> index ccc499cfa1..7e6648b03a 100644
> --- a/chardev/char-socket.c
> +++ b/chardev/char-socket.c
> @@ -454,7 +454,9 @@ static int tcp_chr_sync_read(Chardev *chr, const uint8_t 
> *buf, int len)
>          return 0;
>      }
>  
> +    qio_channel_set_blocking(s->ioc, true, NULL);
>      size = tcp_chr_recv(chr, (void *) buf, len);
> +    qio_channel_set_blocking(s->ioc, false, NULL);
>      if (size == 0) {
>          /* connection closed */
>          tcp_chr_disconnect(chr);
> 

Acked-by: Paolo Bonzini <address@hidden>