Re: [Qemu-devel] [PATCH v3 09/10] nbd: refactor tracing

[Eric Blake]

On 07/07/2017 10:29 AM, Vladimir Sementsov-Ogievskiy wrote:
> Reorganize traces: move, reword, add information, drop extra ones.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>  nbd/client.c |  3 ---
>  nbd/server.c | 30 +++++++++---------------------
>  2 files changed, 9 insertions(+), 24 deletions(-)
> 

> +++ b/nbd/server.c

> @@ -1039,7 +1043,8 @@ static int nbd_co_receive_request(NBDRequestData *req, 
> NBDRequest *request,
>          return -EIO;
>      }
>  
> -    TRACE("Decoding type");
> +    TRACE("Decoding type: handle = %" PRIu64 ", type = %" PRIu16,
> +          request->handle, request->type);

Now just prints a number,

>  
>      if (request->type != NBD_CMD_WRITE) {
>          /* No payload, we are ready to read the next request.  */
> @@ -1049,7 +1054,6 @@ static int nbd_co_receive_request(NBDRequestData *req, 
> NBDRequest *request,
>      if (request->type == NBD_CMD_DISC) {
>          /* Special case: we're going to disconnect without a reply,
>           * whether or not flags, from, or len are bogus */
> -        TRACE("Request type is DISCONNECT");

where we used to print a name. But for debugging purposes, we can still
figure things out, so not a show-stopper.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature