Re: [Qemu-devel] [PATCH v2 3/8] Convert error_report() to warn_report()

[Max Reitz]

On 2017-07-08 01:21, Alistair Francis wrote:
> Convert all uses of error_report("[Ww]arning:"... to use warn_report()
> instead. This helps standardise on a single method of printing warnings
> to the user.
> 
> All of the warnings were changed using this command:
>     find ./* -type f -exec sed -i \
>     's|error_report.*[Ww]arning: |warn_report("|g' {} +
> 
> Then the white space changes where manually fixed afterwards.
> 
> The test-qdev-global-props test case was manually updated to ensure that
> this patch passes make check (as the test cases are case sensitive).
> 
> Signed-off-by: Alistair Francis <address@hidden>
> Suggested-by: Thomas Huth <address@hidden>
> Cc: Jeff Cody <address@hidden>
> Cc: Kevin Wolf <address@hidden>
> Cc: Max Reitz <address@hidden>
> Cc: Ronnie Sahlberg <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Peter Lieven <address@hidden>
> Cc: Josh Durgin <address@hidden>
> Cc: "Richard W.M. Jones" <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Cc: Peter Crosthwaite <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Cc: "Aneesh Kumar K.V" <address@hidden>
> Cc: Greg Kurz <address@hidden>
> Cc: Rob Herring <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Cc: Peter Chubb <address@hidden>
> Cc: Eduardo Habkost <address@hidden>
> Cc: Marcel Apfelbaum <address@hidden>
> Cc: "Michael S. Tsirkin" <address@hidden>
> Cc: Igor Mammedov <address@hidden>
> Cc: David Gibson <address@hidden>
> Cc: Alexander Graf <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Cc: Jason Wang <address@hidden>
> Cc: Marcelo Tosatti <address@hidden>
> Cc: Christian Borntraeger <address@hidden>
> Cc: Cornelia Huck <address@hidden>
> Cc: Stefan Hajnoczi <address@hidden>
> Acked-by: David Gibson <address@hidden>
> Acked-by: Greg Kurz <address@hidden>
> Acked-by: Cornelia Huck <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> ---
> V2:
>  - Fix quotation issues
>  - Update commit message
>  - Include full command
> 
>  block/backup.c                 | 10 +++++-----
>  block/gluster.c                |  2 +-
>  block/iscsi.c                  |  6 +++---
>  block/nfs.c                    | 12 ++++++------
>  block/rbd.c                    |  6 +++---
>  block/ssh.c                    |  4 ++--
>  blockdev.c                     |  2 +-
>  cpus.c                         |  2 +-
>  hw/9pfs/9p.c                   |  2 +-
>  hw/arm/highbank.c              |  6 +++---
>  hw/arm/imx25_pdk.c             |  6 +++---
>  hw/arm/kzm.c                   |  6 +++---
>  hw/core/machine.c              | 10 +++++-----
>  hw/core/qdev-properties.c      |  8 ++++----
>  hw/i386/acpi-build.c           | 10 +++++-----
>  hw/i386/kvm/pci-assign.c       |  6 +++---
>  hw/i386/pc.c                   | 12 ++++++------
>  hw/i386/pc_piix.c              |  8 ++++----
>  hw/i386/pc_q35.c               |  6 +++---
>  hw/misc/aspeed_sdmc.c          |  8 ++++----
>  hw/nvram/fw_cfg.c              |  2 +-
>  hw/pci-host/piix.c             |  2 +-
>  hw/ppc/pnv.c                   |  6 +++---
>  hw/ppc/spapr.c                 |  4 ++--
>  hw/ppc/spapr_iommu.c           |  2 +-
>  hw/scsi/scsi-bus.c             |  6 +++---
>  hw/usb/dev-smartcard-reader.c  |  6 +++---
>  hw/usb/redirect.c              |  2 +-
>  net/tap-linux.c                |  2 +-
>  target/i386/cpu.c              | 22 +++++++++++-----------
>  target/i386/kvm.c              | 12 ++++++------
>  target/s390x/cpu_models.c      |  6 +++---
>  target/s390x/kvm.c             |  4 ++--
>  tests/test-qdev-global-props.c |  6 +++---
>  trace/control.c                |  8 ++++----
>  vl.c                           | 20 ++++++++++----------
>  36 files changed, 121 insertions(+), 121 deletions(-)

[...]

> diff --git a/block/gluster.c b/block/gluster.c
> index addceed6eb..531e72df56 100644
> --- a/block/gluster.c
> +++ b/block/gluster.c
> @@ -345,7 +345,7 @@ static int qemu_gluster_parse_uri(BlockdevOptionsGluster 
> *gconf,
>          is_unix = true;
>      } else if (!strcmp(uri->scheme, "gluster+rdma")) {
>          gsconf->type = SOCKET_ADDRESS_TYPE_INET;
> -        error_report("Warning: rdma feature is not supported, falling "
> +        warn_report("rdma feature is not supported, falling "
>                       "back to tcp");

You reindented consecutive lines everywhere else, so you may want to do
that here, too.

With that fixed (or even without, as evidently the alignment for
error_report() wasn't quite right all the time either), for block*:

Acked-by: Max Reitz <address@hidden>

>      } else {
>          ret = -EINVAL;

signature.asc
Description: OpenPGP digital signature