qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] chardev: fix parallel device can't be reconnect


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] chardev: fix parallel device can't be reconnect.
Date: Mon, 10 Jul 2017 11:24:52 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0


On 10/07/2017 11:17, Marc-André Lureau wrote:
>     Parallel device don't register be->chr_can_read function, but remote
>     disconnect event is handled in chr_read.
>     So connected parallel device can not detect remote disconnect event.
> 
> What is it that you call a parallel device? you are modifying the socket
> code here. Could you describe a test setup? even better would be to
> write a test in test-char.c.

If I understand the patch correctly, the parallel device is the parallel
port emulation.

It's still not clear to me what scenario the patch is fixing, and the
patch is wrong anyway:

1) because the backend is not supposed to know the details of the
frontend that is connected to it;

2) because the character device's label is not a reliable indicator for
the frontend type (there is no such indicator, because of point 1).

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]