[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] block: fix possible return code clobbering
|
From: |
Denis V. Lunev |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/1] block: fix possible return code clobbering in bdrv_co_pdiscard |
|
Date: |
Mon, 10 Jul 2017 17:31:00 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/10/2017 04:51 PM, Eric Blake wrote:
> On 07/10/2017 03:35 AM, Denis V. Lunev wrote:
>> Signed-off-by: Denis V. Lunev <address@hidden>
>> CC: Stefan Hajnoczi <address@hidden> (supporter:Block I/O path)
>> CC: Fam Zheng <address@hidden> (supporter:Block I/O path)
> The commit message is a bit sparse; I might have written:
>
> block: fix shadowed variable in bdrv_co_pdiscard
>
> We've had a shadowed 'ret' variable, which risks returning the wrong
> value, introduced in commit b9c64947.
thank you for the proposal.
Den