[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH resend v4 0/3] Generate APEI GHES table and dyna
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH resend v4 0/3] Generate APEI GHES table and dynamically record CPER |
Date: |
Tue, 11 Jul 2017 15:43:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
Hi Dongjiu,
On 07/11/17 08:46, Dongjiu Geng wrote:
> [...]
So my followup is off-topic, but I'd like to point out that the patch /
email threading in this series is still incorrect.
These are the "sent" timestamps on the messages:
Date: Tue, 11 Jul 2017 14:46:19 +0800
Date: Tue, 11 Jul 2017 14:46:31 +0800 (+12 seconds)
Date: Tue, 11 Jul 2017 14:46:41 +0800 (+10 seconds)
Date: Tue, 11 Jul 2017 14:47:00 +0800 (+19 seconds)
This tells me that you are mailing out the patches one by one. That's
not how most people post their patches.
(Side remark: while git-send-email can still get the threading right
with individual posting, for that you would have to provide the first
email's Message-Id individually to all the subsequent commands, and the
emails show that this didn't happen.)
Instead, you should invoke git-send-email with all the messages *at
once*. Then git-send-email can set up the threading automatically. From
git-send-email(1):
> GIT-SEND-EMAIL(1) Git Manual GIT-SEND-EMAIL(1)
>
> NAME
> git-send-email - Send a collection of patches as emails
>
> SYNOPSIS
> git send-email [options] <file|directory|rev-list options>...
> git send-email --dump-aliases
>
> DESCRIPTION
> Takes the patches given on the command line and emails them
> out. Patches can be specified as files, directories (which
> will send all files in the directory), or directly as a
> revision list. In the last case, any format accepted by git-
> format-patch(1) can be passed to git send-email.
So send the patches with
git send-email *.patch
or put all the patches into a temporary directory, and run
git send-email patch-dir/
Thanks,
Laszlo