[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v12 00/27] translate: [tcg] Generic translation
From: |
Lluís Vilanova |
Subject: |
Re: [Qemu-devel] [PATCH v12 00/27] translate: [tcg] Generic translation framework |
Date: |
Wed, 12 Jul 2017 14:10:12 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Alex Bennée writes:
> Lluís Vilanova <address@hidden> writes:
>> This series proposes a generic (target-agnostic) instruction translation
>> framework.
>>
>> It basically provides a generic main loop for instruction disassembly, which
>> calls target-specific functions when necessary. This generalization makes
>> inserting new code in the main loop easier, and helps in keeping all targets
>> in
>> synch as to the contents of it.
> As has been mentioned elsewhere I think we need to spend a little time
> making sure we have well defined common semantics for the as many of the
> translation exit conditions as possible so the others really are just
> special conditions for each architecture.
>> This series also paves the way towards adding events to trace guest code
>> execution (BBLs and instructions).
> I'm looking forward to it, it is certainly going in the right direction
> and will make instrumentation a lot easier ;-)
>> I've ported i386/x86-64 and arm/aarch64 as an example to see how it fits in
>> the
>> current organization, but will port the rest when this series gets
>> merged.
> Are you confident the other architectures will be as amenable to this
> port? I guess we want to avoid being in a position of having a partial
> port in progress for too long.
> Anyway I'm done with my review pass for now, I look forward to future
> revisions ;-)
I've only skimmed through a few other targets, but there seems to be a pattern
that follows the same type of changes. In fact, most of them are just moving
code around into refactored hooks. But I don't want these to be my "last famous
words" :)
Thanks,
Lluis
- Re: [Qemu-devel] [PATCH v12 21/27] target/arm: [tcg] Port to translate_insn, (continued)
- [Qemu-devel] [PATCH v12 22/27] target/arm: [tcg, a64] Port to translate_insn, Lluís Vilanova, 2017/07/07
- [Qemu-devel] [PATCH v12 23/27] target/arm: [tcg] Port to tb_stop, Lluís Vilanova, 2017/07/07
- [Qemu-devel] [PATCH v12 24/27] target/arm: [tcg, a64] Port to tb_stop, Lluís Vilanova, 2017/07/07
- [Qemu-devel] [PATCH v12 25/27] target/arm: [tcg] Port to disas_log, Lluís Vilanova, 2017/07/07
- [Qemu-devel] [PATCH v12 26/27] target/arm: [tcg, a64] Port to disas_log, Lluís Vilanova, 2017/07/07
- [Qemu-devel] [PATCH v12 27/27] target/arm: [tcg] Port to generic translation framework, Lluís Vilanova, 2017/07/07
- Re: [Qemu-devel] [PATCH v12 00/27] translate: [tcg] Generic translation framework, Alex Bennée, 2017/07/12
- Re: [Qemu-devel] [PATCH v12 00/27] translate: [tcg] Generic translation framework,
Lluís Vilanova <=