[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 0/3] tests/pxe-testt: add testcase using vho
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH RFC 0/3] tests/pxe-testt: add testcase using vhost-user-bridge |
Date: |
Wed, 12 Jul 2017 04:59:57 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH RFC 0/3] tests/pxe-testt: add testcase using
vhost-user-bridge
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
3dbb5f8 libvhost-user: quit when no more data received
86c4c2b tests/pxe-test: add testcase using vhost-user-bridge
13bef71 tests/vhost-user-bridge: disable debug output by default
=== OUTPUT BEGIN ===
Checking PATCH 1/3: tests/vhost-user-bridge: disable debug output by default...
Checking PATCH 2/3: tests/pxe-test: add testcase using vhost-user-bridge...
WARNING: line over 80 characters
#61: FILE: tests/pxe-test.c:26:
+#define QEMU_CMD_MEM "--enable-kvm -m %d -object
memory-backend-file,id=mem,size=%dM,"\
ERROR: spaces required around that '*' (ctx:WxV)
#114: FILE: tests/pxe-test.c:79:
+ gchar *vubr_args[] = {NULL, NULL, NULL, NULL};
^
ERROR: space required after that ',' (ctx:VxV)
#157: FILE: tests/pxe-test.c:122:
+ g_assert_cmpint (g_remove(g_strdup_printf("%s/%s", tmpfs,VUBR_SOCK)),
^
ERROR: code indent should never use tabs
#158: FILE: tests/pxe-test.c:123:
+^I^I ==, 0);$
total: 3 errors, 1 warnings, 147 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/3: libvhost-user: quit when no more data received...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH RFC 0/3] tests/pxe-testt: add testcase using vhost-user-bridge, Jens Freimann, 2017/07/12
- [Qemu-devel] [PATCH RFC 1/3] tests/vhost-user-bridge: disable debug output by default, Jens Freimann, 2017/07/12
- [Qemu-devel] [PATCH RFC 2/3] tests/pxe-test: add testcase using vhost-user-bridge, Jens Freimann, 2017/07/12
- [Qemu-devel] [PATCH RFC 3/3] libvhost-user: quit when no more data received, Jens Freimann, 2017/07/12
- Re: [Qemu-devel] [PATCH RFC 0/3] tests/pxe-testt: add testcase using vhost-user-bridge,
no-reply <=
- Re: [Qemu-devel] [PATCH RFC 0/3] tests/pxe-testt: add testcase using vhost-user-bridge, no-reply, 2017/07/12
- Re: [Qemu-devel] [PATCH RFC 0/3] tests/pxe-testt: add testcase using vhost-user-bridge, Michael S. Tsirkin, 2017/07/12