Re: [Qemu-devel] [PATCH v5 00/11] Implement network booting in the s390-ccw BIOS

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v5 00/11] Implement network booting in the 
s390-ccw BIOS

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
f1b84c9 pc-bios/s390-ccw: Link libnet into the netboot image and do the TFTP 
load
e503195 pc-bios/s390-ccw: Add virtio-net driver code
b1c645d pc-bios/s390-ccw: Add core files for the network bootloading program
e73c389 roms/SLOF: Update submodule to latest status
b54fa54 pc-bios/s390-ccw: Add code for virtio feature negotiation
bbd5677 pc-bios/s390-ccw: Remove unused structs from virtio.h
a576747 pc-bios/s390-ccw: Move byteswap functions to a separate header
5b05827 pc-bios/s390-ccw: Add a write() function for stdio
a71e81f pc-bios/s390-ccw: Move virtio-block related functions into a separate 
file
6f36844 pc-bios/s390-ccw: Move ebc2asc to sclp.c
d609df1 pc-bios/s390-ccw: Move libc functions to separate header

=== OUTPUT BEGIN ===
Checking PATCH 1/11: pc-bios/s390-ccw: Move libc functions to separate header...
Checking PATCH 2/11: pc-bios/s390-ccw: Move ebc2asc to sclp.c...
Checking PATCH 3/11: pc-bios/s390-ccw: Move virtio-block related functions into 
a separate file...
Checking PATCH 4/11: pc-bios/s390-ccw: Add a write() function for stdio...
ERROR: externs should be avoided in .c files
#23: FILE: pc-bios/s390-ccw/sclp.c:15:
+long write(int fd, const void *str, size_t len);

total: 1 errors, 0 warnings, 37 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/11: pc-bios/s390-ccw: Move byteswap functions to a separate 
header...
Checking PATCH 6/11: pc-bios/s390-ccw: Remove unused structs from virtio.h...
Checking PATCH 7/11: pc-bios/s390-ccw: Add code for virtio feature 
negotiation...
Checking PATCH 8/11: roms/SLOF: Update submodule to latest status...
Checking PATCH 9/11: pc-bios/s390-ccw: Add core files for the network 
bootloading program...
ERROR: externs should be avoided in .c files
#127: FILE: pc-bios/s390-ccw/netmain.c:26:
+extern char _start[];

ERROR: externs should be avoided in .c files
#130: FILE: pc-bios/s390-ccw/netmain.c:29:
+IplParameterBlock iplb __attribute__((aligned(PAGE_SIZE)));

total: 2 errors, 0 warnings, 204 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/11: pc-bios/s390-ccw: Add virtio-net driver code...
Checking PATCH 11/11: pc-bios/s390-ccw: Link libnet into the netboot image and 
do the TFTP load...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden