qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function


From: no-reply
Subject: Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function
Date: Wed, 12 Jul 2017 08:14:12 -0700 (PDT)

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v4 0/7]  Implement a warning_report function

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
7bcf244 Convert error_report*_err() to warn_report*_err()
bc92029 error: Implement the warn and free Error functions
cd2966c char-socket: Report TCP socket waiting as information
d8040ca hw/i386: Improve some of the warning messages
0570401 Convert error_report() to warn_report()
d65db5e error: Functions to report warnings and informational messages
e217a60 util/qemu-error: Rename error_print_loc() to be more generic

=== OUTPUT BEGIN ===
Checking PATCH 1/7: util/qemu-error: Rename error_print_loc() to be more 
generic...
Checking PATCH 2/7: error: Functions to report warnings and informational 
messages...
Checking PATCH 3/7: Convert error_report() to warn_report()...
ERROR: line over 90 characters
#722: FILE: tests/test-qdev-global-props.c:235:
+    g_test_trap_assert_stderr("*warning: global dynamic-prop-type-bad.prop3 
has invalid class name\n*");

WARNING: line over 80 characters
#726: FILE: tests/test-qdev-global-props.c:237:
+    g_test_trap_assert_stderr("*warning: global nohotplug-type.prop5=105 not 
used\n*");

ERROR: line over 90 characters
#727: FILE: tests/test-qdev-global-props.c:238:
+    g_test_trap_assert_stderr("*warning: global nondevice-type.prop6 has 
invalid class name\n*");

total: 2 errors, 1 warnings, 571 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/7: hw/i386: Improve some of the warning messages...
Checking PATCH 5/7: char-socket: Report TCP socket waiting as information...
Checking PATCH 6/7: error: Implement the warn and free Error functions...
Checking PATCH 7/7: Convert error_report*_err() to warn_report*_err()...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]