[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/9] block: List anonymous device BBs in query-b
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 5/9] block: List anonymous device BBs in query-block |
Date: |
Wed, 12 Jul 2017 10:47:40 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/12/2017 07:57 AM, Kevin Wolf wrote:
> Instead of listing only monitor-owned BlockBackends in query-block, also
> add those anonymous BlockBackends that are owned by a qdev device and as
> such under the control of the user.
>
> This allows to use query-block to inspect BlockBackends for the modern
"allows to VERB" is not idiomatic; better is "allows VERBing" (as in
"allows using query-block"); or "allows SUBJECT to VERB" (as in the
verbose "allows the client to use query-block"). For your particular
wording choice, it is also possible to do "allows the use of
query-block", although that rewrite is not possible for all VERB.
> configuration syntax with -blockdev and -device.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/qapi.c | 2 +-
> hmp.c | 8 ++++----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/9] block: -device drive=<node-name> fixes, Kevin Wolf, 2017/07/12
- [Qemu-devel] [PATCH 1/9] block: Make blk_get_attached_dev_id() public, Kevin Wolf, 2017/07/12
- [Qemu-devel] [PATCH 2/9] block/qapi: Add qdev device name to query-block, Kevin Wolf, 2017/07/12
- [Qemu-devel] [PATCH 3/9] block: Make blk_all_next() public, Kevin Wolf, 2017/07/12
- [Qemu-devel] [PATCH 4/9] block/qapi: Use blk_all_next() for query-block, Kevin Wolf, 2017/07/12
- [Qemu-devel] [PATCH 5/9] block: List anonymous device BBs in query-block, Kevin Wolf, 2017/07/12
- Re: [Qemu-devel] [PATCH 5/9] block: List anonymous device BBs in query-block,
Eric Blake <=
- [Qemu-devel] [PATCH 7/9] scsi-disk: bdrv_attach_dev() for empty CD-ROM, Kevin Wolf, 2017/07/12
- [Qemu-devel] [PATCH 6/9] ide: bdrv_attach_dev() for empty CD-ROM, Kevin Wolf, 2017/07/12
- [Qemu-devel] [PATCH 8/9] qemu-iotests: Test 'info block', Kevin Wolf, 2017/07/12
- [Qemu-devel] [PATCH 9/9] qemu-iotests: Test unplug of -device without drive, Kevin Wolf, 2017/07/12