[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/7] hw/i386: Improve some of the warning mes
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v4 4/7] hw/i386: Improve some of the warning messages |
Date: |
Wed, 12 Jul 2017 18:32:53 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Alistair Francis <address@hidden> writes:
> Signed-off-by: Alistair Francis <address@hidden>
> Suggested-by: Eduardo Habkost <address@hidden>
[...]
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index 1653a47f0a..c915719b0c 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -101,9 +101,11 @@ static void pc_q35_init(MachineState *machine)
> lowmem = pcms->max_ram_below_4g;
> if (machine->ram_size - lowmem > lowmem &&
> lowmem & ((1ULL << 30) - 1)) {
> - warn_report("Large machine and max_ram_below_4g(%"PRIu64
> - ") not a multiple of 1G; possible bad performance.",
> - pcms->max_ram_below_4g);
> + warn_report("Large machine as the ram size (0x%" PRIx64 ") is
> more"
> + " then twice the size of the internal limit"
than
> + " (0x%" PRIx64 ") and max_ram_below_4g (%"PRIu64")"
Space between string literal and PRIu64, please.
> + " note a multiple of 1G; possible bad performance.",
> + machine->ram_size, lowmem, pcms->max_ram_below_4g);
> }
> }
- [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function, Alistair Francis, 2017/07/12
- [Qemu-devel] [PATCH v4 1/7] util/qemu-error: Rename error_print_loc() to be more generic, Alistair Francis, 2017/07/12
- [Qemu-devel] [PATCH v4 2/7] error: Functions to report warnings and informational messages, Alistair Francis, 2017/07/12
- [Qemu-devel] [PATCH v4 4/7] hw/i386: Improve some of the warning messages, Alistair Francis, 2017/07/12
- [Qemu-devel] [PATCH v4 6/7] error: Implement the warn and free Error functions, Alistair Francis, 2017/07/12
- [Qemu-devel] [PATCH v4 5/7] char-socket: Report TCP socket waiting as information, Alistair Francis, 2017/07/12
- [Qemu-devel] [PATCH v4 3/7] Convert error_report() to warn_report(), Alistair Francis, 2017/07/12
- [Qemu-devel] [PATCH v4 7/7] Convert error_report*_err() to warn_report*_err(), Alistair Francis, 2017/07/12
- Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function, no-reply, 2017/07/12
- Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function, Markus Armbruster, 2017/07/12