[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/22] translate-all: report correct avg host TB
|
From: |
Emilio G. Cota |
|
Subject: |
Re: [Qemu-devel] [PATCH 12/22] translate-all: report correct avg host TB size |
|
Date: |
Wed, 12 Jul 2017 14:45:34 -0400 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Jul 12, 2017 at 16:25:45 +0100, Alex Bennée wrote:
> Emilio G. Cota <address@hidden> writes:
(snip)
> I think having the __attribute__ stuff is confusing. Why don't we just
> do what the newer debug stuff does:
>
> modified accel/tcg/translate-all.c
> @@ -66,6 +66,12 @@
> /* make various TB consistency checks */
> /* #define DEBUG_TB_CHECK */
>
> +#if defined(DEBUG_TB_FLUSH)
> +#define DEBUG_TB_FLUSH_GATE 1
> +#else
> +#define DEBUG_TB_FLUSH_GATE 0
> +#endif
(snip)
> Which will a) ensure all the debug code is compiled even when not
> enabled and b) the compiler won't bitch at you when it optimises stuff
> away.
>
> Better?
Much better! The unused attribute was there to achieve this, but what
you propose is much better.
E.