Re: [Qemu-devel] [PATCH 08/11] s390x/flic: introduce modify_ais_mode callback

[Christian Borntraeger]

On 07/12/2017 05:07 PM, Cornelia Huck wrote:
>> +
>> +    switch (mode) {
>> +    case SIC_IRQ_MODE_ALL:
>> +        flic->simm &= ~AIS_MODE_MASK(isc);
>> +        flic->nimm &= ~AIS_MODE_MASK(isc);
>> +        break;
>> +    case SIC_IRQ_MODE_SINGLE:
>> +        flic->simm |= AIS_MODE_MASK(isc);
>> +        flic->nimm &= ~AIS_MODE_MASK(isc);
> 
> Can we have some documentation about the meaning of simm/nimm in qemu?
> The one from the patch description of the respective kernel patch would
> be fine.

Do you want to have that description as part of the patch description or
somewhere in the docs folder or somewhere in the code?


> 
>> +        break;
>> +    default:
>> +        return -EINVAL;
>> +    }
>> +
>> +    return 0;
>> +}
>> +
>>
> 
> (...)
> 
>> @@ -406,6 +427,7 @@ typedef struct KVMS390FLICStateClass {
>>  
>>  static void kvm_s390_flic_realize(DeviceState *dev, Error **errp)
>>  {
>> +    S390FLICState *fs = S390_FLIC_COMMON(dev);
>>      KVMS390FLICState *flic_state = KVM_S390_FLIC(dev);
>>      struct kvm_create_device cd = {0};
>>      struct kvm_device_attr test_attr = {0};
>> @@ -438,6 +460,7 @@ static void kvm_s390_flic_realize(DeviceState *dev, 
>> Error **errp)
>>      flic_state->clear_io_supported = !ioctl(flic_state->fd,
>>                                              KVM_HAS_DEVICE_ATTR, test_attr);
>>  
>> +    fs->ais_supported = false;
> 
> The patch actually enabling this for kvm is in the next batch of
> patches, I assume?


yes, will hopefully come today.