Re: [Qemu-devel] [PULL 0/9] Error reporting patches for 2017-07-13

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 0/9] Error reporting patches for 2017-07-13

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
43225f4 Convert error_report*_err() to warn_report*_err()
dc458e0 error: Implement the warn and free Error functions
018d8da char-socket: Report TCP socket waiting as information
8713482 Convert error_report() to warn_report()
f75e632 error: Functions to report warnings and informational messages
65bc053 util/qemu-error: Rename error_print_loc() to be more generic
739dd32 websock: Don't try to set *errp directly
ca32b14 block: Don't try to set *errp directly
818cfa7 xilinx: Fix latent error handling bug

=== OUTPUT BEGIN ===
Checking PATCH 1/9: xilinx: Fix latent error handling bug...
Checking PATCH 2/9: block: Don't try to set *errp directly...
Checking PATCH 3/9: websock: Don't try to set *errp directly...
Checking PATCH 4/9: util/qemu-error: Rename error_print_loc() to be more 
generic...
Checking PATCH 5/9: error: Functions to report warnings and informational 
messages...
Checking PATCH 6/9: Convert error_report() to warn_report()...
ERROR: line over 90 characters
#725: FILE: tests/test-qdev-global-props.c:235:
+    g_test_trap_assert_stderr("*warning: global dynamic-prop-type-bad.prop3 
has invalid class name\n*");

WARNING: line over 80 characters
#729: FILE: tests/test-qdev-global-props.c:237:
+    g_test_trap_assert_stderr("*warning: global nohotplug-type.prop5=105 not 
used\n*");

ERROR: line over 90 characters
#730: FILE: tests/test-qdev-global-props.c:238:
+    g_test_trap_assert_stderr("*warning: global nondevice-type.prop6 has 
invalid class name\n*");

total: 2 errors, 1 warnings, 571 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/9: char-socket: Report TCP socket waiting as information...
Checking PATCH 8/9: error: Implement the warn and free Error functions...
Checking PATCH 9/9: Convert error_report*_err() to warn_report*_err()...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden