[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 40/41] vl: fix breakage of -tb-size
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 40/41] vl: fix breakage of -tb-size |
Date: |
Thu, 13 Jul 2017 16:24:33 +0200 |
From: "Emilio G. Cota" <address@hidden>
Commit e7b161d573 ("vl: add tcg_enabled() for tcg related code") adds
a check to exit the program when !tcg_enabled() while parsing the -tb-size
flag.
It turns out that when the -tb-size flag is evaluated, tcg_enabled() can
only return 0, since it is set (or not) much later by configure_accelerator().
Fix it by unconditionally exiting if the flag is passed to a QEMU binary
built with !CONFIG_TCG.
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
vl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index f7560de..85cdbbf 100644
--- a/vl.c
+++ b/vl.c
@@ -3933,10 +3933,10 @@ int main(int argc, char **argv, char **envp)
configure_rtc(opts);
break;
case QEMU_OPTION_tb_size:
- if (!tcg_enabled()) {
- error_report("TCG is disabled");
- exit(1);
- }
+#ifndef CONFIG_TCG
+ error_report("TCG is disabled");
+ exit(1);
+#endif
if (qemu_strtoul(optarg, NULL, 0, &tcg_tb_size) < 0) {
error_report("Invalid argument to -tb-size");
exit(1);
--
1.8.3.1
- [Qemu-devel] [PULL 24/41] gdbstub: modernise DEBUG_GDB, (continued)
- [Qemu-devel] [PULL 24/41] gdbstub: modernise DEBUG_GDB, Paolo Bonzini, 2017/07/13
- [Qemu-devel] [PULL 26/41] qom/cpu: remove host_tid field, Paolo Bonzini, 2017/07/13
- [Qemu-devel] [PULL 29/41] memory/iommu: QOM'fy IOMMU MemoryRegion, Paolo Bonzini, 2017/07/13
- [Qemu-devel] [PULL 30/41] memory/iommu: introduce IOMMUMemoryRegionClass, Paolo Bonzini, 2017/07/13
- [Qemu-devel] [PULL 31/41] nbd: Create struct for tracking export info, Paolo Bonzini, 2017/07/13
- [Qemu-devel] [PULL 32/41] nbd: Don't bother tracing an NBD_OPT_ABORT response failure, Paolo Bonzini, 2017/07/13
- [Qemu-devel] [PULL 33/41] nbd: Expose and debug more NBD constants, Paolo Bonzini, 2017/07/13
- [Qemu-devel] [PULL 39/41] nbd: Implement NBD_INFO_BLOCK_SIZE on client, Paolo Bonzini, 2017/07/13
- [Qemu-devel] [PULL 38/41] nbd: Implement NBD_INFO_BLOCK_SIZE on server, Paolo Bonzini, 2017/07/13
- [Qemu-devel] [PULL 37/41] nbd: Implement NBD_OPT_GO on client, Paolo Bonzini, 2017/07/13
- [Qemu-devel] [PULL 40/41] vl: fix breakage of -tb-size,
Paolo Bonzini <=
- Re: [Qemu-devel] [PULL 00/41] Misc patches for QEMU 2.10 soft freeze, no-reply, 2017/07/13