Re: [Qemu-devel] [PATCH v2 3/8] virtio: introduce virtqueue_error

[Ladi Prosek]

On Thu, Jul 13, 2017 at 4:42 PM, Cornelia Huck <address@hidden> wrote:
> On Thu, 13 Jul 2017 13:02:32 +0200
> Ladi Prosek <address@hidden> wrote:
>
>> Most virtio error output pertains to a specific virtqueue so it makes
>> sense to include the queue index in error messages. This commit makes
>> all error output in virtio.c use the newly introduced virtqueue_error.
>
> Split out the change introducing virtqueue_error(), as this patch is
> quite large?

Will do, thanks!

>>
>> Suggested-by: Stefan Hajnoczi <address@hidden>
>> Signed-off-by: Ladi Prosek <address@hidden>
>> ---
>>  hw/virtio/virtio.c         | 98 
>> ++++++++++++++++++++++++++++------------------
>>  include/hw/virtio/virtio.h |  1 +
>>  2 files changed, 60 insertions(+), 39 deletions(-)
>
> I like the change. Feel free to add
>
> Reviewed-by: Cornelia Huck <address@hidden>