Re: [Qemu-devel] [PATCH 0/6] seccomp: feature refactoring

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/6] seccomp: feature refactoring

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
079aeb3 seccomp: adding documentation to new seccomp model
f29594f seccomp: add resourcecontrol argument to command line
c6406bd seccomp: add spawn argument to command line
6e1cf86 seccomp: add elevateprivileges argument to command line
afa8dce seccomp: add obsolete argument to command line
1653a6a seccomp: changing from whitelist to blacklist

=== OUTPUT BEGIN ===
Checking PATCH 1/6: seccomp: changing from whitelist to blacklist...
ERROR: code indent should never use tabs
#315: FILE: vl.c:1043:
+^I}$

total: 1 errors, 0 warnings, 295 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/6: seccomp: add obsolete argument to command line...
ERROR: "foo * bar" should be "foo *bar"
#131: FILE: vl.c:1040:
+        const char * value = NULL;

ERROR: space required after that ',' (ctx:VxV)
#133: FILE: vl.c:1042:
+        value = qemu_opt_get(opts,"obsolete");
                                  ^

total: 2 errors, 0 warnings, 108 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/6: seccomp: add elevateprivileges argument to command line...
ERROR: code indent should never use tabs
#84: FILE: qemu-seccomp.c:129:
+^I^I^I^I  privileged_syscalls[i].num, 0);$

ERROR: space required after that ',' (ctx:VxV)
#119: FILE: vl.c:1053:
+        value = qemu_opt_get(opts,"elevateprivileges");
                                  ^

ERROR: code indent should never use tabs
#127: FILE: vl.c:1061:
+^I^I/* calling prctl directly because we're$

ERROR: code indent should never use tabs
#128: FILE: vl.c:1062:
+^I^I * not sure if host has CAP_SYS_ADMIN set*/$

ERROR: code indent should never use tabs
#129: FILE: vl.c:1063:
+^I^Iprctl(PR_SET_NO_NEW_PRIVS, 1);$

ERROR: code indent should never use tabs
#130: FILE: vl.c:1064:
+^I    }$

total: 6 errors, 0 warnings, 98 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/6: seccomp: add spawn argument to command line...
ERROR: code indent should never use tabs
#79: FILE: qemu-seccomp.c:154:
+^I^I^I^I^I  spawn_syscalls[i].priority);$

ERROR: space required after that ',' (ctx:VxV)
#107: FILE: vl.c:1071:
+        value = qemu_opt_get(opts,"spawn");
                                  ^

total: 2 errors, 0 warnings, 81 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/6: seccomp: add resourcecontrol argument to command line...
WARNING: line over 80 characters
#82: FILE: qemu-seccomp.c:176:
+            rc = seccomp_rule_add(ctx, SCMP_ACT_KILL, 
resourcecontrol_syscalls[i].num, 0);

ERROR: code indent should never use tabs
#87: FILE: qemu-seccomp.c:181:
+^I^I^I^I^I  resourcecontrol_syscalls[i].priority);$

ERROR: space required after that ',' (ctx:VxV)
#116: FILE: vl.c:1082:
+        value = qemu_opt_get(opts,"resourcecontrol");
                                  ^

total: 2 errors, 1 warnings, 90 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/6: seccomp: adding documentation to new seccomp model...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden