[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 5/6] target/arm: use gen_goto_tb for ISB hand
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 5/6] target/arm: use gen_goto_tb for ISB handling |
|
Date: |
Fri, 14 Jul 2017 15:20:39 +0100 |
On 14 July 2017 at 15:12, Alex Bennée <address@hidden> wrote:
> Peter Maydell <address@hidden> writes:
>> Why do we need to clear the low bit of s->pc for ISB?
>> s->pc is the actual PC, not the "PC and low bit indicates
>> Thumb mode" form that jump addresses have.
>
> It's what gen_lookup_tb does to it's PC before the calculated jump. If
> it can never happen I can get rid of it.
Hmm, I think that it's unnecessary, but since we were doing this before
I guess better to make cleaning it up be a separate patch.
thanks
-- PMM
- [Qemu-devel] [PATCH v4 0/6] arm: fixes for eret, isb and DISAS_UPDATE handling, Alex Bennée, 2017/07/13
- [Qemu-devel] [PATCH v4 6/6] target/arm: use DISAS_EXIT for eret handling, Alex Bennée, 2017/07/13
- [Qemu-devel] [PATCH v4 2/6] target/arm/translate: make DISAS_UPDATE match declared semantics, Alex Bennée, 2017/07/13
- [Qemu-devel] [PATCH v4 3/6] target/arm/translate.h: expand comment on DISAS_EXIT, Alex Bennée, 2017/07/13
- [Qemu-devel] [PATCH v4 4/6] target/arm/translate: ensure gen_goto_tb sets exit flags, Alex Bennée, 2017/07/13
- [Qemu-devel] [PATCH v4 1/6] include/exec/exec-all: document common exit conditions, Alex Bennée, 2017/07/13
- [Qemu-devel] [PATCH v4 5/6] target/arm: use gen_goto_tb for ISB handling, Alex Bennée, 2017/07/13
- Re: [Qemu-devel] [PATCH v4 0/6] arm: fixes for eret, isb and DISAS_UPDATE handling, Peter Maydell, 2017/07/14