Re: [Qemu-devel] [PATCH v7 0/6] fsdev: qmp interface for io throttling

[Pradeep Jagadeesh]

On 7/14/2017 4:26 PM, Manos Pitsidianakis wrote:
> On Fri, Jul 14, 2017 at 03:15:06PM +0200, Pradeep Jagadeesh wrote:
> > Hi Manos,
> >
> > Thanks for sharing the link to your code patch.
> >
> > On 7/14/2017 2:22 PM, Manos Pitsidianakis wrote:
> > > Hello Pradeep, you might be interested in my work on refactoring the
> > > block layer's throttling interface in my series:
> > > https://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg04191.html
> > Sure will have a look.
> > > In this series you copy the existing legacy interface we want to get rid
> > > of. I think it will be easier work for you to use the changes introduced
> > > in my patches when they are merged.
> > So, should I wait till they are in?. Actually my throttle patches for
> > fsdev are already upstream (2.9). Now I am just introducing the
> > qmp/hmp interfaces for the same.
>
> If you plan on using ThrottleGroups, probably yes, I think, because we'd
> have duplicate interfaces afterwards instead of a unified one. You'd
> have to introduce a qmp/hmp command to set fsdev throttle now and after
> you use throttle groups it will become obsolete.
I am not using ThrottleGroups in near future.

-Pradeep

> > > Have you thought about using throttle groups? It'd mean many devices
> > > sharing the same limits. This way the interfaces can be unified.  Please
> > > read docs/throttle.txt and see if it would be useful for you.
> >
> > I have read about the throttle group, last year when I was
> > implementing the throttle feature for fsdev.My open source work
> > depends on the projects I/my group work on. So, when I have more
> > bandwidth work on those, I will surely take it up. Throttle group
> > option may be useful feature even in case of fsdev devices.
> >
> > Regards,
> > Pradeep