[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/28] m68k: replace cpu_m68k_init() with cpu_ge
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH 14/28] m68k: replace cpu_m68k_init() with cpu_generic_init() |
|
Date: |
Sat, 15 Jul 2017 10:05:22 +0200 |
Am Fri, 14 Jul 2017 15:52:05 +0200
schrieb Igor Mammedov <address@hidden>:
> call register_m68k_insns() at realize time which makes
> cpu_m68k_init() typical object creation function.
> As result we can replace it with cpu_generic_init()
> which does the same job, reducing code duplication a bit.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> CC: Thomas Huth <address@hidden>
> CC: Laurent Vivier <address@hidden>
> ---
> target/m68k/cpu.h | 3 +--
> hw/m68k/an5206.c | 2 +-
> hw/m68k/mcf5208.c | 2 +-
> target/m68k/cpu.c | 2 ++
> target/m68k/helper.c | 20 --------------------
> 5 files changed, 5 insertions(+), 24 deletions(-)
Patch looks good, and the Coldfire images that I have still boot fine:
Tested-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH 06/28] sparc: convert cpu features to qdev properties, (continued)
- [Qemu-devel] [PATCH 06/28] sparc: convert cpu features to qdev properties, Igor Mammedov, 2017/07/14
- [Qemu-devel] [PATCH 08/28] x86: extract legacy cpu features format parser, Igor Mammedov, 2017/07/14
- [Qemu-devel] [PATCH 09/28] sparc: replace custom cpu feature parsing with cpu_legacy_parse_featurestr(), Igor Mammedov, 2017/07/14
- [Qemu-devel] [PATCH 10/28] sparc: replace cpu_sparc_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
- [Qemu-devel] [PATCH 11/28] s390x: replace cpu_s390x_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
- [Qemu-devel] [PATCH 12/28] alpha: replace cpu_alpha_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
- [Qemu-devel] [PATCH 13/28] hppa: replace cpu_hppa_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
- [Qemu-devel] [PATCH 14/28] m68k: replace cpu_m68k_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
[Qemu-devel] [PATCH 16/28] nios2: replace cpu_nios2_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
[Qemu-devel] [PATCH 15/28] microblaze: replace cpu_mb_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
[Qemu-devel] [PATCH 17/28] tilegx: replace cpu_tilegx_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14