Re: [Qemu-devel] [PATCH v3 2/8] target/s390x: Implement CONVERT UNICODE insns

[Richard Henderson]

On 07/14/2017 10:25 PM, Aurelien Jarno wrote:
> That said I still wonder if we can get generators like that:
>
> | static void in1_r1n(DisasContext *s, DisasFields *f, DisasOps *o)
> | {
> |     int r1 = get_field(s->fields, r1);
> |     o->in1 = tcg_const_i32(r1);
> |
> | #define SPEC_in1_r1n 0
>
> and
>
> | static void in1_r1n_even(DisasContext *s, DisasFields *f, DisasOps *o)
> | {
> |     int r1 = get_field(s->fields, r1);
> |     o->in1 = tcg_const_i32(r1);
> |
> | #define SPEC_in1_r1n_even SPEC_r1_even

Well, not in to o->in1, obviously, since that's TCGv_i32 not TCGv_i64.
I suppose we could add something of the sort though.


r~