[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] slirp: Handle error returns from sosendo
|
From: |
Samuel Thibault |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] slirp: Handle error returns from sosendoob() |
|
Date: |
Sat, 15 Jul 2017 14:27:41 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
Dr. David Alan Gilbert, on ven. 14 juil. 2017 15:24:19 +0100, wrote:
> * Peter Maydell (address@hidden) wrote:
> > sosendoob() can return a failure code, but all its callers ignore it.
> > This is OK in sbappend(), as the comment there states -- we will try
> > again later in sowrite(). Add a (void) cast to tell Coverity so.
> > In sowrite() we do need to check the return value -- we should handle
> > a write failure in sosendoob() the same way we handle a write failure
> > for the normal data.
> >
> > Signed-off-by: Peter Maydell <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Applied to my tree, thanks!
Samuel