[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/28] m68k: replace cpu_m68k_init() with cpu_ge
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH 14/28] m68k: replace cpu_m68k_init() with cpu_generic_init() |
Date: |
Sat, 15 Jul 2017 22:57:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
Le 15/07/2017 à 20:08, Richard Henderson a écrit :
> On 07/14/2017 03:52 AM, Igor Mammedov wrote:
>> @@ -230,6 +230,8 @@ static void m68k_cpu_realizefn(DeviceState *dev,
>> Error **errp)
>> M68kCPUClass *mcc = M68K_CPU_GET_CLASS(dev);
>> Error *local_err = NULL;
>> + register_m68k_insns(&cpu->env);
>> +
>
> I think it would make more sense to do this during m68k_tcg_init.
I agree.
Laurent
- [Qemu-devel] [PATCH 09/28] sparc: replace custom cpu feature parsing with cpu_legacy_parse_featurestr(), (continued)
- [Qemu-devel] [PATCH 09/28] sparc: replace custom cpu feature parsing with cpu_legacy_parse_featurestr(), Igor Mammedov, 2017/07/14
- [Qemu-devel] [PATCH 10/28] sparc: replace cpu_sparc_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
- [Qemu-devel] [PATCH 11/28] s390x: replace cpu_s390x_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
- [Qemu-devel] [PATCH 12/28] alpha: replace cpu_alpha_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
- [Qemu-devel] [PATCH 13/28] hppa: replace cpu_hppa_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
- [Qemu-devel] [PATCH 14/28] m68k: replace cpu_m68k_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
[Qemu-devel] [PATCH 16/28] nios2: replace cpu_nios2_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
[Qemu-devel] [PATCH 15/28] microblaze: replace cpu_mb_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
[Qemu-devel] [PATCH 17/28] tilegx: replace cpu_tilegx_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
[Qemu-devel] [PATCH 18/28] xtensa: replace cpu_xtensa_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14
[Qemu-devel] [PATCH 20/28] sh4: replace cpu_sh4_init() with cpu_generic_init(), Igor Mammedov, 2017/07/14