Re: [Qemu-devel] [Qemu-arm] [PATCH v5 1/6] armv7m: Convert bitband.source-mamory to DEFINE_PROP_LINK

[Philippe Mathieu-Daudé]

On 07/16/2017 11:38 PM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>   hw/arm/armv7m.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c
> index c8a11f2..8efc4e8 100644
> --- a/hw/arm/armv7m.c
> +++ b/hw/arm/armv7m.c
> @@ -97,12 +97,6 @@ static void bitband_init(Object *obj)
>       BitBandState *s = BITBAND(obj);
>       SysBusDevice *dev = SYS_BUS_DEVICE(obj);
>   
> -    object_property_add_link(obj, "source-memory",
> -                             TYPE_MEMORY_REGION,
> -                             (Object **)&s->source_memory,
> -                             qdev_prop_allow_set_link_before_realize,
> -                             OBJ_PROP_LINK_UNREF_ON_RELEASE,
> -                             &error_abort);
>       memory_region_init_io(&s->iomem, obj, &bitband_ops, s,
>                             "bitband", 0x02000000);
>       sysbus_init_mmio(dev, &s->iomem);
> @@ -349,6 +343,8 @@ void armv7m_load_kernel(ARMCPU *cpu, const char 
> *kernel_filename, int mem_size)
>   
>   static Property bitband_properties[] = {
>       DEFINE_PROP_UINT32("base", BitBandState, base, 0),
> +    DEFINE_PROP_LINK("source-memory", BitBandState, source_memory,
> +                     TYPE_MEMORY_REGION, MemoryRegion *),
>       DEFINE_PROP_END_OF_LIST(),
>   };
>