Re: [Qemu-devel] [PATCH] add scripts/indent.sh

[Marc-André Lureau]

Hi

On Mon, Jul 17, 2017 at 12:49 PM Gerd Hoffmann <address@hidden> wrote:

> On Mon, 2017-07-17 at 10:36 +0000, Marc-André Lureau wrote:
> > Hi
> >
> > On Mon, Jul 17, 2017 at 12:18 PM Gerd Hoffmann <address@hidden>
> > wrote:
> > > Script to reformat sources in qemu style.
> > >
> > > Signed-off-by: Gerd Hoffmann <address@hidden>
> >
> > A quite powerful approach would be to use clang-format: https://lists
> > .gnu.org/archive/html/qemu-devel/2015-10/msg01278.html
> >
> > It comes with a bunch of editor integration and scripts. My config
> > could use a bit more tweaking though, I haven't been using it for a
> > while, and newer version have more options.
>
> Hmm, I want reformat all audio stuff to qemu code style some day, the
> current situation where patches are either break qemu code style or
> lead to mixed-style in the audio source files isn't very good.
>
> I don't mind much which tool we use for that, I picked indent mostly
> because I know that one.  If clang-format can do that too, fine with
> me.  I'm missing documentation though, there is no man-page and there
> isn't anything in /usr/share/doc/clang-3.4.2 either ...
>

Afaik, most of clang-tools documentation is only in html. The most recent
version is online at https://clang.llvm.org/docs/ClangFormat.html &
https://clang.llvm.org/docs/ClangFormatStyleOptions.html

Another advantage of using clang-format, is that it should be used by other
clang refactoring tools (as in my clang-tidy series for ex).


> cheers,
>   Gerd
>
> --
Marc-André Lureau