[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 13/14] virtion-net: Prefer is_power_of_2()
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL 13/14] virtion-net: Prefer is_power_of_2() |
Date: |
Mon, 17 Jul 2017 20:21:44 +0800 |
From: Michal Privoznik <address@hidden>
We have a function that checks if given number is power of two.
We should prefer it instead of expanding the check on our own.
Signed-off-by: Michal Privoznik <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
hw/net/virtio-net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 5630a9e..657d099 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -1942,7 +1942,7 @@ static void virtio_net_device_realize(DeviceState *dev,
Error **errp)
*/
if (n->net_conf.rx_queue_size < VIRTIO_NET_RX_QUEUE_MIN_SIZE ||
n->net_conf.rx_queue_size > VIRTQUEUE_MAX_SIZE ||
- (n->net_conf.rx_queue_size & (n->net_conf.rx_queue_size - 1))) {
+ !is_power_of_2(n->net_conf.rx_queue_size)) {
error_setg(errp, "Invalid rx_queue_size (= %" PRIu16 "), "
"must be a power of 2 between %d and %d.",
n->net_conf.rx_queue_size, VIRTIO_NET_RX_QUEUE_MIN_SIZE,
--
2.7.4
- [Qemu-devel] [PULL 03/14] net/filter-mirror.c: Introduce parameter for filter_send(), (continued)
- [Qemu-devel] [PULL 03/14] net/filter-mirror.c: Introduce parameter for filter_send(), Jason Wang, 2017/07/17
- [Qemu-devel] [PULL 04/14] net/filter-mirror.c: Make filter mirror support vnet support., Jason Wang, 2017/07/17
- [Qemu-devel] [PULL 05/14] net/filter-mirror.c: Add new option to enable vnet support for filter-redirector, Jason Wang, 2017/07/17
- [Qemu-devel] [PULL 06/14] net/colo.c: Make vnet_hdr_len as packet property, Jason Wang, 2017/07/17
- [Qemu-devel] [PULL 07/14] net/colo-compare.c: Introduce parameter for compare_chr_send(), Jason Wang, 2017/07/17
- [Qemu-devel] [PULL 08/14] net/colo-compare.c: Make colo-compare support vnet_hdr_len, Jason Wang, 2017/07/17
- [Qemu-devel] [PULL 09/14] net/colo.c: Add vnet packet parse feature in colo-proxy, Jason Wang, 2017/07/17
- [Qemu-devel] [PULL 10/14] net/colo-compare.c: Add vnet packet's tcp/udp/icmp compare, Jason Wang, 2017/07/17
- [Qemu-devel] [PULL 11/14] net/filter-rewriter.c: Make filter-rewriter support vnet_hdr_len, Jason Wang, 2017/07/17
- [Qemu-devel] [PULL 12/14] docs/colo-proxy.txt: Update colo-proxy usage of net driver with vnet_header, Jason Wang, 2017/07/17
- [Qemu-devel] [PULL 13/14] virtion-net: Prefer is_power_of_2(),
Jason Wang <=
- [Qemu-devel] [PULL 14/14] virtio-net: fix offload ctrl endian, Jason Wang, 2017/07/17
- Re: [Qemu-devel] [PULL 00/14] Net patches, Peter Maydell, 2017/07/18