qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/5] Easier conversion from qapi to qobject


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 0/5] Easier conversion from qapi to qobject
Date: Mon, 17 Jul 2017 11:02:35 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 07/17/2017 10:56 AM, Eric Blake wrote:
> I'm not sure if I'm posted this before, or if it is a cleanup I've
> just been sitting on locally.  In all likelihood, it will miss
> tomorrow's freeze due to lack of review time, and thus be 2.11
> material, but we'll see...

Answering myself, it was part of my larger (mostly-unreviewed) attempt
to rip out dynamic JSON parsing [1]. But it is independent enough that
it warrants its own thread for separate review.

[1] https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg05425.html

> 
> Eric Blake (5):
>   qapi: Add QAPI_TO_QOBJECT() convenience macro
>   nbd: Use simpler QAPI_TO_QOBJECT()
>   nfs: Use simpler QAPI_TO_QOBJECT()
>   qapi: Use simpler QAPI_TO_QOBJECT()
>   blockdev: Use simpler QAPI_TO_QOBJECT()
> 
>  include/qapi/qobject-output-visitor.h | 19 +++++++++++++++++++
>  block/nbd.c                           |  8 +++-----
>  block/nfs.c                           |  8 +++-----
>  block/qapi.c                          |  7 +++----
>  blockdev.c                            | 13 ++++---------
>  qapi/qobject-output-visitor.c         | 16 ++++++++++++++++
>  6 files changed, 48 insertions(+), 23 deletions(-)

The diffstat is misleading because of the size of the additional
interface and comments.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]