Re: [Qemu-devel] [PATCH] Unified Socket Transport

[Anton Ivanov]

OK.

I can split it into series before next submission.

A.


On 18/07/17 08:27, Daniel P. Berrange wrote:
> On Tue, Jul 18, 2017 at 07:06:27AM +0100, address@hidden wrote:
> > From: Anton Ivanov <address@hidden>
> >
> > 1. Creates a common recvmmsg backend for socket transports
> > 2. Migrates L2TPv3 to the new backend
> > 3. Adds gre socket transport - a vm can attach directly to GRE
> > 4. Adds raw socket transport - a vm can attach directly to an
> > Ethernet interface
> > 5. Adds simplistic static VXLAN tunnel transport (no
> > control plane).
> > 6. Sets up some of the infrastructure for future addition of
> > sendmmsg
> This list of features is a really strong sign that you should split
> this patch up into a patch series with multiple commits, each commit
> adding / changing a single feature. Especially keep refactoring of
> existing code completely separate from adding of new features.
>
> Regards,
> Daniel

--
Anton R. Ivanov

Cambridge Greys Limited, England and Wales company No 10273661
http://www.cambridgegreys.com/