Re: [Qemu-devel] [PATCH 1/2] vfio/ccw: allocate irq info with the right size

[Cornelia Huck]

On Tue, 18 Jul 2017 03:49:25 +0200
Dong Jia Shi <address@hidden> wrote:

> From: Jing Zhang <address@hidden>
> 
> When allocating memory for the vfio_irq_info parameter of the
> VFIO_DEVICE_GET_IRQ_INFO ioctl, we used the wrong size. Let's
> fix it by using the right size.
> 
> Reviewed-by: Dong Jia Shi <address@hidden>
> Signed-off-by: Jing Zhang <address@hidden>
> Signed-off-by: Dong Jia Shi <address@hidden>
> ---
>  hw/vfio/ccw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c
> index 12d0262336..8d97b53e77 100644
> --- a/hw/vfio/ccw.c
> +++ b/hw/vfio/ccw.c
> @@ -168,7 +168,7 @@ static void vfio_ccw_register_io_notifier(VFIOCCWDevice 
> *vcdev, Error **errp)
>          return;
>      }
>  
> -    argsz = sizeof(*irq_set);
> +    argsz = sizeof(*irq_info);
>      irq_info = g_malloc0(argsz);
>      irq_info->index = VFIO_CCW_IO_IRQ_INDEX;
>      irq_info->argsz = argsz;

irq_set is larger than irq_info, but yes, let's do this correctly.

Out of curiosity, how did you spot this?