Re: [Qemu-devel] [PATCH 25/29] libqos: use ARRAY_SIZE macro

[Marc-André Lureau]

On Mon, Jul 17, 2017 at 11:10 PM, Philippe Mathieu-Daudé
<address@hidden> wrote:
> Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---

Reviewed-by: Marc-André Lureau <address@hidden>


>
> No entry in MAINTAINERS for tests/libqos/* does it deserve it's own entry?
>

It would, do you want to candidate? :)

>  tests/libqos/libqos.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/libqos/libqos.c b/tests/libqos/libqos.c
> index 6226546c28..0edb7e99ba 100644
> --- a/tests/libqos/libqos.c
> +++ b/tests/libqos/libqos.c
> @@ -258,7 +258,7 @@ void generate_pattern(void *buffer, size_t len, size_t 
> cycle_len)
>      p = rand() % 256;
>      for (i = 0; i < len; i++) {
>          tx[i] = p++ % 256;
> -        if (i % cycle_len == 0) {
> +        if (QEMU_IS_ALIGNED(i, cycle_len)) {
>              p = rand() % 256;
>          }
>      }
> --
> 2.13.2
>
>



-- 
Marc-André Lureau