Re: [Qemu-devel] [PATCH 19/29] disas: use QEMU_IS_ALIGNED macro

[Marc-André Lureau]

Hi

On Mon, Jul 17, 2017 at 11:09 PM, Philippe Mathieu-Daudé
<address@hidden> wrote:
> Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

Reviewed-by: Marc-André Lureau <address@hidden>


> ---
>
> There is no entry for this file in MAINTAINERS, should it go under 
> TCG/Overall?

That would make sense to me.

>
>  disas.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/disas.c b/disas.c
> index d335c55bbf..8b59448286 100644
> --- a/disas.c
> +++ b/disas.c
> @@ -151,7 +151,7 @@ static int print_insn_objdump(bfd_vma pc, 
> disassemble_info *info,
>      info->read_memory_func(pc, buf, n, info);
>
>      for (i = 0; i < n; ++i) {
> -        if (i % 32 == 0) {
> +        if (QEMU_IS_ALIGNED(i, 32)) {
>              info->fprintf_func(info->stream, "\n%s: ", prefix);
>          }
>          info->fprintf_func(info->stream, "%02x", buf[i]);
> --
> 2.13.2
>
>



-- 
Marc-André Lureau