[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/29] ds1338: use QEMU_IS_ALIGNED macro
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 07/29] ds1338: use QEMU_IS_ALIGNED macro |
Date: |
Tue, 18 Jul 2017 10:23:19 -0300 |
On Tue, Jul 18, 2017 at 7:23 AM, Alastair D'Silva <address@hidden> wrote:
> I'm not sure this makes sense - we're dealing with time here.
Indeed, thanks for your review!
>> --- a/hw/timer/ds1338.c
>> +++ b/hw/timer/ds1338.c
>> @@ -65,7 +65,7 @@ static void capture_current_time(DS1338State *s)
>> s->nvram[1] = to_bcd(now.tm_min);
>> if (s->nvram[2] & HOURS_12) {
>> int tmp = now.tm_hour;
>> - if (tmp % 12 == 0) {
>> + if (QEMU_IS_ALIGNED(tmp, 12)) {
>> tmp += 12;
>> }
>> if (tmp <= 12) {
>> @@ -154,7 +154,7 @@ static int ds1338_send(I2CSlave *i2c, uint8_t data)
>> if (data & HOURS_PM) {
>> tmp += 12;
>> }
>> - if (tmp % 12 == 0) {
>> + if (QEMU_IS_ALIGNED(tmp, 12)) {
>> tmp -= 12;
>> }
>> now.tm_hour = tmp;
- Re: [Qemu-devel] [PATCH 03/29] qemu-img: use QEMU_IS_ALIGNED macro, (continued)
- [Qemu-devel] [PATCH 04/29] scsi-disk: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 05/29] block: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 06/29] migration/block: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 07/29] ds1338: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 08/29] ui: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 10/29] net/rocker: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 09/29] net: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 11/29] s390x/sclp: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18
- [Qemu-devel] [PATCH 12/29] sm501: use QEMU_IS_ALIGNED macro, Philippe Mathieu-Daudé, 2017/07/18