Re: [Qemu-devel] Hacks for building on gcc 7 / Fedora 26

[Philippe Mathieu-Daudé]

On 07/17/2017 02:36 PM, Peter Maydell wrote:
> On 17 July 2017 at 18:29, Eric Blake <address@hidden> wrote:
> > On 07/17/2017 11:46 AM, Dr. David Alan Gilbert wrote:
[...]
> > > You may find this doesn't help in some windows builds;  the assert
> > > functions aren't always marked as noreturn (because they pop up a dialog
> > > that asks you whether you want to run into a debugger etc).
> >
> > How would it not help?  Are we using gcc 7 on windows builds?
>
> At some point in the future we are likely to, because my
> w32/w64 test setups use the Ubuntu gcc-mingw-w64-x86-64
> packages, and so as I upgrade my desktop they will move
> forward to newer gcc versions. (More generally our users
> may do so before me ;-))

The MXE toolchain (mxe.cc) provides GCC version 5.4.0 and compiles fine:

win32:
https://app.shippable.com/github/philmd/qemu/runs/32/2/console

# file i386-softmmu/qemu-system-i386.exe
i386-softmmu/qemu-system-i386.exe: PE32 executable (console) Intel 
80386, for MS Windows

and win64:
https://app.shippable.com/github/philmd/qemu/runs/32/3/console

# file x86_64-softmmu/qemu-system-x86_64.exe
x86_64-softmmu/qemu-system-x86_64.exe: PE32+ executable (console) 
x86-64, for MS Windows

> We should be consistent -- if we can't trust assert() to
> be marked nonreturn, as it seems we can't, then we shouldn't
> write new code that assumes it always is, even if today
> it doesn't happen to bite us on the compiler/host combinations
> we're testing right now.

And there is also the problem when you compiles with CPPFLAGS+=-DNDEBUG 
some oldschool guys still have in their ~/.cshrc ;)

Phil.