[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'n
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type |
Date: |
Tue, 18 Jul 2017 22:02:57 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 07/18/2017 02:43 PM, Markus Armbruster wrote:
>> Markus Armbruster <address@hidden> writes:
>>
>>> Eric Blake <address@hidden> writes:
>>>
>>>> On 07/18/2017 09:53 AM, Eric Blake wrote:
>>>>> On 07/18/2017 08:41 AM, Markus Armbruster wrote:
>>>>>> I expect the 'null' type to be useful mostly for members of alternate
>>>>>> types.
>>>>>>
>>>>>> Signed-off-by: Markus Armbruster <address@hidden>
>>>>>> ---
>>>>>
>>>>
>>>>> Reviewed-by: Eric Blake <address@hidden>
>>>>
>>>> Actually, do we need to update any qapi docs to mention the new builtin
>>>> type?
>>>
>>> Yes, we do. I'll give it a shot.
>>
>> Incremental patch appended. May I keep your R-by?
>>
>>
>> diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt
>> index 52e3874..6d8e00c 100644
>> --- a/docs/devel/qapi-code-gen.txt
>> +++ b/docs/devel/qapi-code-gen.txt
>> @@ -283,6 +283,7 @@ The following types are predefined, and map to C as
>> follows:
>> accepts size suffixes
>> bool bool JSON true or false
>> any QObject * any JSON value
>> + null QNull * JSON null
>> QType QType JSON string matching enum QType values
>
> I might have grouped 'null' next to 'bool', but your layout is also
> okay. Yes, my R-b is still valid with this addition.
I like your order better; lines swapped. Thanks!
Re: [Qemu-devel] [PATCH for-2.10 03/10] qapi: Introduce a first class 'null' type, Daniel P. Berrange, 2017/07/18
[Qemu-devel] [PATCH for-2.10 06/10] hmp: Clean up and simplify hmp_migrate_set_parameter(), Markus Armbruster, 2017/07/18
[Qemu-devel] [PATCH for-2.10 01/10] qapi: Separate type QNull from QObject, Markus Armbruster, 2017/07/18