[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] replace struct ucontext with ucontext_t type
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] replace struct ucontext with ucontext_t type |
Date: |
Tue, 18 Jul 2017 20:07:02 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 06/29/2017 09:09 AM, Laurent Vivier wrote:
> ...
>> diff --git a/linux-user/signal.c b/linux-user/signal.c
>> index 3d18d1b3ee..2c55a4f600 100644
>> --- a/linux-user/signal.c
>> +++ b/linux-user/signal.c
>> @@ -3346,7 +3346,7 @@ static void setup_rt_frame(int sig, struct
>> target_sigaction *ka,
>> *
>> * a0 = signal number
>> * a1 = pointer to siginfo_t
>> - * a2 = pointer to struct ucontext
>> + * a2 = pointer to ucontext_t
>> *
>> * $25 and PC point to the signal handler, $29 points to the
>> * struct sigframe.
>> @@ -3733,7 +3733,7 @@ struct target_signal_frame {
>>
>> struct rt_signal_frame {
>> siginfo_t info;
>> - struct ucontext uc;
>> + ucontext_t uc;
>> uint32_t tramp[2];
>> };
>>
>> @@ -3949,7 +3949,7 @@ struct rt_signal_frame {
>> siginfo_t *pinfo;
>> void *puc;
>> siginfo_t info;
>> - struct ucontext uc;
>> + ucontext_t uc;
>> uint16_t retcode[4]; /* Trampoline code. */
>> };
>>
>
> I think these two rt_signal_frame are unused and can be removed.
Sounds like a separate patch, though.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature